Add start_update_with_start_workflow to Otel Interceptor #1150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Restore existing tracing test to original state
cretz
reviewed
Oct 13, 2025
temporalio/client.py
Outdated
| [temporalio.api.workflowservice.v1.StartWorkflowExecutionResponse], None | ||
| ] | ||
| _on_start_error: Callable[[BaseException], None] | ||
| headers: Mapping[str, temporalio.api.common.v1.Payload] |
There was a problem hiding this comment.
Unlike some other SDKs, this SDK chose to break apart the input into start and update classes, and put headers in each of those. Can you just use those instead of adding a third new header field to this set of input? Yes, it may mean copying the OTel header to a second place in the OTel interceptor, but that makes more sense than to add a new header field for everyone unnecessarily that force overwrites the more specific ones.
…into both operation inputs in otel interceptor
…extra call to payload conversion
tconley1428
approved these changes
Oct 14, 2025
cretz
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
start_update_with_start_workflowto the OpenTelemetry interceptor.headersfield totemporalio.client.StartWorkflowUpdateWithStartInputStartWorkflowUpdateWithStartInputto populate headers for both operations sent intemporalio.client._ClientImpl.start_update_with_start_workflowCloses [Bug] OTEL metadata missing for execute_update_with_start_workflow #1053
How was this tested:
A new test was added to verify that start_update_with_start_workflow produces correct spans when called on an in flight workflow and a new workflow.